Skip to content

chore: Release 4.70.1#7040

Open
diegolmello wants to merge 3 commits intodevelopfrom
build-4.70.1
Open

chore: Release 4.70.1#7040
diegolmello wants to merge 3 commits intodevelopfrom
build-4.70.1

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Mar 5, 2026

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores

    • Version downgraded to 4.70.1 across Android, iOS, and package configuration.
  • Refactor

    • Simplified InvertedScrollView component architecture for improved maintainability.

@diegolmello diegolmello temporarily deployed to approve_e2e_testing March 5, 2026 14:50 — with GitHub Actions Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2da5ba57-6059-40e0-8df4-e2cff68f296c

📥 Commits

Reviewing files that changed from the base of the PR and between dbba268 and 15ab0d6.

📒 Files selected for processing (6)
  • android/app/build.gradle
  • app/views/RoomView/List/components/InvertedScrollView.tsx
  • ios/RocketChatRN.xcodeproj/project.pbxproj
  • ios/RocketChatRN/Info.plist
  • ios/ShareRocketChatRN/Info.plist
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: ESLint and Test / run-eslint-and-test
  • GitHub Check: format
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-02-05T13:55:00.974Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.

Applied to files:

  • package.json
🔇 Additional comments (7)
android/app/build.gradle (1)

93-93: Version update looks correct.

Line 93 updates versionName to 4.70.1 and aligns with the release bump across platforms.

ios/RocketChatRN.xcodeproj/project.pbxproj (1)

2938-2938: NotificationService marketing version is consistently updated.

Lines 2938 and 2991 correctly align Debug and Release to 4.70.1.

Also applies to: 2991-2991

ios/RocketChatRN/Info.plist (1)

31-31: Main iOS bundle short version update is correct.

Line 31 sets CFBundleShortVersionString to 4.70.1 as expected for this release.

package.json (1)

3-3: Package version bump is clean.

Line 3 updates the app package version to 4.70.1 without side effects.

ios/ShareRocketChatRN/Info.plist (1)

29-29: Share extension version update is correct.

Line 29 updates CFBundleShortVersionString to 4.70.1, matching the release.

app/views/RoomView/List/components/InvertedScrollView.tsx (2)

12-24: The wrapper simplification is solid.

The ref forwarding and prop passthrough preserve standard ScrollView behavior while introducing the custom content view for accessibility ordering.


4-4: No issues with native registration. The InvertedScrollContentViewManager is properly registered with the matching REACT_CLASS name "InvertedScrollContentView" and added to the package's view managers list in InvertedScrollPackage.java. The requireNativeComponent call will resolve correctly at runtime.

			> Likely an incorrect or invalid review comment.

Walkthrough

This pull request downgrades the app version from 4.71.0 to 4.70.1 across all platform configurations (Android, iOS, and Node package), and refactors the InvertedScrollView component to a simpler Android-focused implementation that removes custom ref forwarding and layout logic.

Changes

Cohort / File(s) Summary
Version Downgrade
android/app/build.gradle, ios/RocketChatRN.xcodeproj/project.pbxproj, ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist, package.json
Updated versionName/CFBundleShortVersionString/MARKETING_VERSION from 4.71.0 to 4.70.1 across all platform configuration files.
InvertedScrollView Refactor
app/views/RoomView/List/components/InvertedScrollView.tsx
Replaced complex multi-hook native-integration implementation with simplified Android-focused wrapper. Removed internal state, ref forwarding logic, custom native props management, and public methods (scrollTo, scrollToEnd, flashScrollIndicators). Changed ref type from custom InvertedScrollViewRef to standard ScrollView. Component now delegates directly to native InvertedScrollContentView within a standard ScrollView.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested labels

type: feature

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Release 4.70.1' directly aligns with the primary changes: version bumps across all configuration files (package.json, Info.plist files, build.gradle, and xcodeproj) from 4.71.0 to 4.70.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello deployed to official_android_build March 5, 2026 14:54 — with GitHub Actions Active
@diegolmello diegolmello deployed to experimental_ios_build March 5, 2026 14:54 — with GitHub Actions Active
@diegolmello diegolmello deployed to experimental_android_build March 5, 2026 14:54 — with GitHub Actions Active
@diegolmello diegolmello deployed to official_ios_build March 5, 2026 14:54 — with GitHub Actions Active
@diegolmello diegolmello had a problem deploying to upload_official_android March 5, 2026 15:38 — with GitHub Actions Error
@diegolmello diegolmello had a problem deploying to upload_experimental_android March 5, 2026 15:38 — with GitHub Actions Error
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Android Build Available

Rocket.Chat Experimental 4.70.1.108341

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRvUH2WX4qs1BC8zC1GheqcARhlOn9nTNz9sLErxX7f3HqoAiYRx_ZKNA7bB7jmLaSJFP4m2-G7YT3EIZsn

@diegolmello diegolmello requested a deployment to upload_official_ios March 5, 2026 17:27 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to upload_official_android March 5, 2026 17:27 — with GitHub Actions Waiting
@diegolmello diegolmello requested a deployment to upload_experimental_android March 5, 2026 17:27 — with GitHub Actions Waiting
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

iOS Build Available

Rocket.Chat Experimental 4.70.1.108343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant