test: external browser oauth webauthn#7030
Draft
OtavioStasiak wants to merge 4 commits intodevelopfrom
Draft
Conversation
Android WebView does not support WebAuthn, preventing users from authenticating with security keys/passkeys through OAuth providers like Keycloak. This changes Custom OAuth to use the device's native browser (via Linking.openURL) instead of the in-app WebView, matching the existing behavior for Google OAuth. The login style is changed from 'popup' to 'redirect' so the Rocket.Chat server generates a rocketchat://auth redirect URL that brings the user back to the app after authentication. Closes #5681 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When OAuth authentication completes in the external browser, the Rocket.Chat server redirects to rocketchat://auth with credential tokens. This adds handling for that redirect URL in parseDeepLinking, setting type to 'oauth' so the deep linking saga can complete the login flow. Also removes the 5-second delay on the deep link listener so OAuth redirects are processed immediately, and adds an AppState listener to catch pending OAuth deep links when the app returns to foreground (needed on iOS where Safari redirects may arrive while app is backgrounded). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the app receives an OAuth callback from the external browser, the SDK WebSocket connection may not be ready yet. This updates handleOAuth to verify the server connection, establish it if needed (waiting for METEOR.SUCCESS), and retry the login with backoff on transient network errors. This is necessary because unlike the in-app WebView flow where the SDK stays connected, the external browser flow may cause the app to be backgrounded and lose its WebSocket connection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OtavioStasiak
requested a deployment
to
approve_e2e_testing
GitHub Actions
Waiting
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OtavioStasiak
requested a deployment
to
official_ios_build
GitHub Actions
Waiting
OtavioStasiak
requested a deployment
to
experimental_android_build
GitHub Actions
Waiting
OtavioStasiak
requested a deployment
to
official_android_build
GitHub Actions
Waiting
OtavioStasiak
temporarily deployed
to
experimental_ios_build
GitHub Actions
Inactive
|
iOS Build Available Rocket.Chat Experimental 4.71.0.108332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments