Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a11y): External link as link on screen reader #6104

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Jan 24, 2025

Proposed changes

Currently, when using TalkBack or VoiceOver to navigate to the SettingsView, the screen reader identifies options that open an external link as buttons. This PR will fix this by updating the accessibilityRole to 'link.'

Issue(s)

https://rocketchat.atlassian.net/browse/MA-111

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 24, 2025 20:39
@OtavioStasiak OtavioStasiak changed the title chore: added accessibility role prop on ListItem content chore(a11y): External link was read as a button Jan 24, 2025
@diegolmello diegolmello changed the title chore(a11y): External link was read as a button feat(a11y): External link as link on screen reader Feb 17, 2025
@diegolmello diegolmello force-pushed the chore-a11y-settings-icon-link branch from 384c017 to b6b2a01 Compare February 17, 2025 16:34
@diegolmello diegolmello merged commit 53e4ea3 into develop Feb 17, 2025
2 of 4 checks passed
@diegolmello diegolmello deleted the chore-a11y-settings-icon-link branch February 17, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants