Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): StatusView #6009

Merged
merged 11 commits into from
Jan 13, 2025
Merged

chore(a11y): StatusView #6009

merged 11 commits into from
Jan 13, 2025

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 18, 2024 •
edited
Loading

Proposed changes

Added accessibility features to the StatusView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-185

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title chore: updated editStatus layout chore (a11y): StatusView Nov 18, 2024
@OtavioStasiak OtavioStasiak changed the title chore (a11y): StatusView chore (a11y):StatusView Nov 18, 2024
@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 20, 2024 01:38
diegolmello
diegolmello requested changes Dec 9, 2024
View reviewed changes
app/stacks/InsideStack.tsx Show resolved Hide resolved
app/views/StatusView/index.tsx Show resolved Hide resolved
app/views/StatusView/index.tsx Outdated Show resolved Hide resolved
app/views/StatusView/index.tsx Outdated Show resolved Hide resolved
app/views/StatusView/index.tsx Outdated Show resolved Hide resolved
app/views/StatusView/index.tsx Outdated Show resolved Hide resolved
@diegolmello diegolmello changed the title chore (a11y):StatusView chore(a11y): StatusView Jan 8, 2025
@OtavioStasiak OtavioStasiak force-pushed the chore-a11y-status-view branch from 6981b55 to 5319df4 Compare January 10, 2025 17:24
@OtavioStasiak OtavioStasiak merged commit ab229f3 into develop Jan 13, 2025
4 of 9 checks passed
@OtavioStasiak OtavioStasiak deleted the chore-a11y-status-view branch January 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtavioStasiak @diegolmello