Fix ObjectGuid constructor calls for TrinityCore automerge compatibility #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation failures in the automerge process caused by recent changes to TrinityCore's ObjectGuid API.
Problem
The automerge was failing with compilation errors related to ObjectGuid constructor calls. Recent changes to TrinityCore deprecated the 3-parameter ObjectGuid constructor for Global GUID types (Item, Player, etc.) that don't require entry IDs.
The old constructor pattern:
Has been replaced with:
ObjectGuid(HighGuid::Item, guid)
Solution
Updated all ObjectGuid constructor calls to use the correct 2-parameter format for Global GUID types. The ObjectGuid header now explicitly deletes the old 3-parameter constructor with
ObjectGuid(HighGuid, uint32, uint64 counter) = delete;
to prevent incorrect usage.Files Changed
Testing
This resolves the automerge build failures and restores functionality to the Transmog and Reforging scripts.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.