-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdf_extract]Add support for parsing pin directions #20
base: master
Are you sure you want to change the base?
Conversation
This is a nice functionnality, but unfortunately that broke well functional extractions. |
Auhc, I was not aware of the test thus I have not ran them. Let me fix them. |
Yes I add it because with this kind of code it's easy to one thing and broke tens others ! |
2097d51
to
b124b94
Compare
@sebcaux please do not merge it yet. If you have a so sweet testing infrastructure in place let me add some test cases for the pin direction parsing as well. |
b124b94
to
f287ca3
Compare
f287ca3
to
99f1f25
Compare
Many datasheets present a table with the pin number, pin name and pin direction columns. This patch add support for the pin direction parsing.
99f1f25
to
40db4d5
Compare
Hm it looks like we have some encoding/poppler version differences between Linux (at me all tests are passing) and the appveyor Windows builds. I will investigate it. |
Many datasheets present a table with the pin number, pin name and pin
direction columns. This patch add support for the pin direction parsing.
Tested with BQ76920 datasheet:


http://www.ti.com/lit/ds/symlink/bq76920.pdf
Example:
Result:
Note: The patch utilize some C++11 only features. If you decide not to use these features let me know in #19 and I will update/downgrade the code.