fix: configurator bugs fixes #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange it was not set up to True anywhere
…vailable through configurator.
… in case s2s was installed and ros2 was not sourced, it was logged that s2s is not installed
MagdalenaKotynia
force-pushed
the
fix/configurator-bugs-fixes
branch
from
a15eb05 to
5d207dd
Compare
Juliaj
reviewed
Jul 18, 2025
| @@ -975,29 +976,30 @@ def setup_steps(): | |||
| step_names = ["👋 Welcome", "🤖 Model Selection", "📊 Tracing"] | |||
| step_render = [welcome, model_selection, tracing] | |||
|
|
|||
| st.session_state.features["s2s"] = True | |||
There was a problem hiding this comment.
Shall we add else to if block below and move this line there ?
There was a problem hiding this comment.
Thank you for the comment. If - else statement does not change behavior of this functionality (in case s2s is not installed, s2s key would be set to False in the first try-except block), but the change suggested by you makes code more readable. I applied your suggestion and additionaly moved try-except statements to else block - to avoid triple warnings in case s2s is not installed. 367e3b3
…ancy - previously, if s2s is not installed, the warning would occur 3 times
maciejmajek
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
KeyErrorexcetpion duringTest Configuration#633 and other bugs discovered during work with the configurator.Proposed Changes
KeyErrorexcetpion duringTest Configuration#633 by setting up the ["s2s"] feature to True if rai_s2s is imported with success.Issues
KeyErrorexcetpion duringTest Configuration#633Testing
KeyErrorexcetpion duringTest Configuration#633s2sinstalled