Skip to content

feat: rai_whoami #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 30, 2025
Merged

feat: rai_whoami #540

merged 27 commits into from
Apr 30, 2025

Conversation

maciejmajek
Copy link
Member

Purpose

rai_whoami has been one of the first packages built under the RAI ecosystem. During migration from 1.x to 2.x, the package has been removed to make space for a new solution designed from the ground up.
rai_whoami allows automatic documentation parsing (images, documens, urdfs) into EmbodimentInfo (e.g., rules, capabilities, system prompt...)

Proposed Changes

  • rai_whoami

Issues

#489 #470

Testing

  • How was it tested, what were the results?

@maciejmajek maciejmajek mentioned this pull request Apr 22, 2025
@maciejmajek maciejmajek linked an issue Apr 23, 2025 that may be closed by this pull request
Copy link
Member

@boczekbartek boczekbartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciejmajek
I briefly checked the new structure and it looks great! I added some minor comments to the code and I have questions:

  1. How about adding an example of the module usage with rai_core agents.
  2. Do you plan to add a tool for RAG in the vector database?

@maciejmajek maciejmajek force-pushed the feat/rai-whoami branch 6 times, most recently from 12b3f98 to ecfa9a6 Compare April 29, 2025 12:34
@maciejmajek maciejmajek requested a review from jmatejcz April 29, 2025 20:47
@jmatejcz
Copy link
Contributor

jmatejcz commented Apr 30, 2025

I followed instructions in README, sample documentation got from https://github.com/RobotecAI/rai/blob/development/docs/create_robots_whoami.md.
Created new folder as structured as stated in README.
info.json and vector db was created properly. Every code sample from README worked fine, instruction were clear,
can't complain about anything.

Copy link
Contributor

@jmatejcz jmatejcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes also looks fine, good job! I posted only 1 question

@maciejmajek maciejmajek merged commit 73785b9 into development Apr 30, 2025
5 checks passed
@maciejmajek maciejmajek deleted the feat/rai-whoami branch April 30, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RAI whoami package
3 participants