-
Notifications
You must be signed in to change notification settings - Fork 39
refactor: demos rewrite, rai_interfaces import guards #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@maciejmajek Could you please resolve confilicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maciejmajek
This PR introduces major changes. I left some initial questions about the plan support rai features.
b972aa3
to
12b13b8
Compare
@maciejmajek I tried:
import rai and I have this output:
I think the purpose of this PR is to have this error only in ros-dependent rai packages like demos, right? |
12b13b8
to
329653b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rai_interfaces
doesn't breakrai
import, warning is shown- tested code for
agriculture
androsbot
demos: code doesn't throw errors, but doesn't work. Refactoring these demos will be tracked under issues: Refactor ROSBotXL demo to RAI 2.0 #477, Add ros2 service related tools to the agriculture demo #474 turtlebot demo
needs refactor: Refactor turtlebot demo to RAI 2.0 #476manipulation demo
works 👍🏼
approving, and let's move forward with demos under issues
Purpose
Using RAI as a standalone framework is unfeasible due to many custom ROS 2 dependencies. Some of the parts of RAI could already be used in a pip install rai installation.
Proposed Changes
This PR adds various changes including:
Issues
Testing