Skip to content

refactor: demos rewrite, rai_interfaces import guards #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 25, 2025

Conversation

maciejmajek
Copy link
Member

@maciejmajek maciejmajek commented Mar 7, 2025

Purpose

Using RAI as a standalone framework is unfeasible due to many custom ROS 2 dependencies. Some of the parts of RAI could already be used in a pip install rai installation.

Proposed Changes

This PR adds various changes including:

  • Guarding the rai_interfaces, rai_openset ... imports
  • Removing deprecated files
  • Rewriting demos

Issues

Testing

  • How was it tested, what were the results?

@maciejmajek maciejmajek changed the title refactor: allow "import rai" in unsourced environment refactor: demos rewrite, rai_interfaces import guards Mar 7, 2025
@maciejmajek maciejmajek requested a review from boczekbartek March 7, 2025 23:19
@boczekbartek
Copy link
Member

@maciejmajek Could you please resolve confilicts?

Copy link
Member

@boczekbartek boczekbartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciejmajek
This PR introduces major changes. I left some initial questions about the plan support rai features.

@boczekbartek
Copy link
Member

@maciejmajek I tried:

rm -rd build install log
import rai

and I have this output:

ModuleNotFoundError: No module named 'rai_interfaces'

I think the purpose of this PR is to have this error only in ros-dependent rai packages like demos, right?

@maciejmajek maciejmajek force-pushed the feat/guard-custom-ros2-imports branch from 12b13b8 to 329653b Compare March 25, 2025 11:08
Copy link
Member

@boczekbartek boczekbartek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciejmajek

approving, and let's move forward with demos under issues

@maciejmajek maciejmajek merged commit 43998d3 into development Mar 25, 2025
9 checks passed
@maciejmajek maciejmajek deleted the feat/guard-custom-ros2-imports branch March 25, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants