fix agents element unexpected replaces bug #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Update(dt), GetActiveAgents(agents) can causes Crowd.agents's element replace that is unexpected. I think, maybe, activeAgents should be used instead modifying agents.
fix unexpected ArgumentOutOfRangeException
Robmaister
reviewed
Sep 14, 2018
| agents[i].State = AgentState.Offmesh; | ||
| agents[i].Corners.Clear(); | ||
| agents[i].NeighborCount = 0; | ||
| agentAnims[idx].InitPos = activeAgents[i].Position; |
Owner
There was a problem hiding this comment.
Can you revert these whitespace changes? Should be consistent with the rest of the file
Robmaister
reviewed
Sep 14, 2018
| //store visited | ||
| for (int i = 0; i < req; i++) | ||
| path[i] = visited[(visited.Count - 1) - i]; | ||
| { |
Owner
There was a problem hiding this comment.
Same here, whitespace of these new lines does not match the spacing of the rest of the file.
Owner
|
I haven't really done much with this project in a while. If there's something that Recast has done to fix this, I'd recommend following suit. I'll take your word that it works, I haven't set up tests for the crowd stuff and don't really think I'll have time to do so in the near future. If you clean up the whitespace issues I commented on, I'll merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Update(dt), GetActiveAgents(agents) can causes Crowd.agents's element replace that is unexpected.
I think, maybe, activeAgents should be used instead modifying agents.