Skip to content

ReactBinding Rewrite #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

ReactBinding Rewrite #7

wants to merge 14 commits into from
+186 −370

Conversation

gaymeowing
Copy link

@gaymeowing gaymeowing commented Sep 29, 2025 •
edited
Loading

Rewrites ReactBinding to be cleaner, and also use less memory as its now properly using metatables.

  • Improve error messages
  • Removes use of pairs()
  • Removes impl table jank
  • Removes createSignal as its no-longer used
  • Remove BindingInternal type as its useless (will be replacing with proper types for each prototype table and each type of binding in React Next, I just cant be bothered to do proper types when its going to be thrown out soon anyways)
  • Rename BindingInternalApi table to ReactBinding
  • Mark __subscribeToBinding as depricated as every binding now has a :_subscribe() method that should be used instead
  • Makes RobloxComponentProps use _:subscribe()
  • Make the update function not iterate twice when firing off callbacks
  • Signal implementation for bindings now uses less memory, as it only uses one table for storing callbacks and nolonger creates connection objects

Checklist before submitting:

  • Added/updated relevant tests
  • Added/updated documentation

@gaymeowing
initial commit
f395e0d
@gaymeowing
formatting + remove useless comment
97dd0d8
@gaymeowing
use IS_BINDING in ReactBinding.join
4185586
@gaymeowing
remove LuauPolyfill from imports
0a57d7e
@gaymeowing
sync wip types
0a39b7d
@gaymeowing
sync before i possibly break and need to revert
8d5e579
@gaymeowing
remove createSignal
a9c3df0 
* nolonger create a connection table for each connection to a binding
* use a boolean for indicating if a callback is suspended
* only use one callbacks table, instead of one for suspended callbacks and one for all callbacks
@gaymeowing
fix __subscribeToBinding export from React.lua and mark it as deprecated
a3520c0
@gaymeowing
make RobloxComponentProps.lua use :_subscribe()
5cb914a
@gaymeowing
*remove double dashes from some stuff because _source has one dash
737bf27 
* fix types
@gaymeowing
improve ReactBinding type
ec30c61
@gaymeowing
don't create wrapper function for bindingPrototype.map
cbec549
@gaymeowing
update subscribeToBinding type and deprecated use
8906fd4
@gaymeowing
Copy link
Author

gaymeowing commented Sep 30, 2025 •
edited
Loading

image

Ran on:

image

Benchmark place: ReactBindingRewriteBenchmark.zip

@gaymeowing
* fix type for update function
3ba710f 
* make naming of bindings consistent
* improve error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaymeowing