-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webhook-notifications.md #1066
base: main
Are you sure you want to change the base?
Conversation
- **Subscription Purchased** — When a user purchases a subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Refunded** — When a user receives a refund for their subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Renewed** — When a user renews a subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Resubscribed** — When a user resubscribes to a subscription, a message is sent containing the subscription and subscriber. | ||
|
||
For more information on subscription events and their fields, see the [Cloud API Subscription](../../cloud/reference/Subscription/) reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The the check for relative links couldn't find the file ../../cloud/reference/Subscription/
. Please double-check and fix the link to this file. Relative links are case-sensitive.
⛔️ This change is a requirement. Please fix it before merging.
- **Subscription Purchased** — When a user purchases a subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Refunded** — When a user receives a refund for their subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Renewed** — When a user renews a subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Resubscribed** — When a user resubscribes to a subscription, a message is sent containing the subscription and subscriber. | ||
|
||
For more information on subscription events and their fields, see the [Cloud API Subscription](../../cloud/reference/Subscription/) reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesnt work. Was it moved or removed?
- **Subscription Purchased** — When a user purchases a subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Refunded** — When a user receives a refund for their subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Renewed** — When a user renews a subscription, a message is sent containing the subscription and subscriber. | ||
- **Subscription Resubscribed** — When a user resubscribes to a subscription, a message is sent containing the subscription and subscriber. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be details for each event payload schema? I dont have info about them
Changes
I added missing webhook notification types, fixed the formatting of json and fixed the javascript example because the "replay attack prevention" did not work at all. If there was no signature sent in the header, validation was skipped. And if the signature was present but it was incorrect, the function did not return.
Checks
By submitting your pull request for review, you agree to the following: