Skip to content

Commit

Permalink
Remove Keyconjurer Upgrade
Browse files Browse the repository at this point in the history
This feature has caused us a lot of problems over the years:

* It would brick itself on Windows if you failed to download the file
  for any reason
* Sometimes the DownloadURL would not be set
* Relying on the releases always being at a specific URL meant that it
  was difficult to change it for any reason (For example, to
support a stable and development release channel)

We are removing this command and will instead move to supporting package
managers like Homebrew for OSX and Chocolatey for Windows.

It is recommended that folks who depend on this project do the same.
  • Loading branch information
punmechanic committed Mar 27, 2024
1 parent c2c1e90 commit 0a2e8e6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 147 deletions.
8 changes: 1 addition & 7 deletions cli/consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ var (
ServerAddress string
Version = "TBD"
BuildTimestamp = "BuildTimestamp is not set"
DownloadURL = "URL not set yet"
// CallbackPorts is a list of ports that will be attempted in no particular order for hosting an Oauth2 callback web server.
// This cannot be set using -ldflags='-X ..' because -X requires that this be a string literal or uninitialized.
//
Expand All @@ -19,10 +18,5 @@ const (
// DefaultTTL for requested credentials in hours
DefaultTTL uint = 1
// DefaultTimeRemaining for new key requests in minutes
DefaultTimeRemaining uint = 5
LinuxAmd64BinaryName string = "keyconjurer-linux-amd64"
LinuxArm64BinaryName string = "keyconjurer-linux-arm64"
WindowsBinaryName string = "keyconjurer-windows.exe"
DarwinArm64BinaryName string = "keyconjurer-darwin-arm64"
DarwinAmd64BinaryName string = "keyconjurer-darwin-amd64"
DefaultTimeRemaining uint = 5
)
1 change: 0 additions & 1 deletion cli/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ func init() {
rootCmd.AddCommand(accountsCmd)
rootCmd.AddCommand(getCmd)
rootCmd.AddCommand(setCmd)
rootCmd.AddCommand(upgradeCmd)
rootCmd.AddCommand(&switchCmd)
rootCmd.AddCommand(&aliasCmd)
rootCmd.AddCommand(&unaliasCmd)
Expand Down
139 changes: 0 additions & 139 deletions cli/upgrade.go

This file was deleted.

0 comments on commit 0a2e8e6

Please sign in to comment.