fix(audit): detect tail-truncation of the Merkle audit chain - #1287
Open
tech4biz-yasha wants to merge 1 commit into
Open
tech4biz-yasha wants to merge 1 commit into
tech4biz-yasha wants to merge 1 commit into
Conversation
The forward-only walk in verify_integrity() cannot detect entries deleted from the end of the persisted chain, since surviving links remain valid. Persist the tip hash to a single-row audit_chain_state table on every write and compare it on load via a new verify_against_stored_tip() method. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The forward-only walk in
verify_integrity()cannot detect entries deleted from the end of the persisted chain, because the surviving links all remain valid. A truncated audit log therefore passes verification.Changes
audit_chain_statetable on every writeverify_against_stored_tip()and compare the stored tip against the recomputed head on loadaudit::tests::test_audit_truncation_is_detected)Testing
audit.rs); workspace clippy has pre-existing failures on the current toolchain, unrelated to this changecargo test --workspacepassesSecurity
Disclosure
Reported privately by email per SECURITY.md on 6 September 2026. No response received, so opening publicly. This is a tamper-detection gap rather than an exploitable flaw.