Skip to content

Conversation

@breyed
Copy link
Contributor

@breyed breyed commented Aug 27, 2025

Previously, the project file had properties that were conditional based on the build target. This caused me to infer that the project was meant to be built multiple times with different targets set as a workaround for proper multi-targeting.

This PR removes the conditions (which weren't needed anyway) and adds a comment clarifying that a single target is intended for use across all frameworks.

Copilot AI review requested due to automatic review settings August 27, 2025 17:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes target-conditional properties from the .NET project file that were unnecessarily complicating the build configuration. The PR clarifies that the project is intended to use a single target framework (net472) that works across all supported .NET versions.

  • Removes conditional PropertyGroup elements that defined preprocessor constants based on target framework
  • Removes condition from ItemGroup that referenced .NET Framework assemblies
  • Adds explanatory comment about framework compatibility strategy

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net472' ">
<ItemGroup>
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the condition from this ItemGroup means these .NET Framework references will now be included for all target frameworks. If this project ever targets non-.NET Framework versions in the future, these references may cause build errors or warnings since they're specific to .NET Framework.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant