Skip to content

Validate redirect URL for token response type #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions oauth/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ var (
ErrInvalidClientSecret = errors.New("Invalid client secret")
// ErrClientIDTaken ...
ErrClientIDTaken = errors.New("Client ID taken")
// ErrInvalidRedirectURL ...
ErrInvalidRedirectURL = errors.New("Invalid redirect URL")
)

// ClientExists returns true if client exists
Expand Down Expand Up @@ -66,6 +68,14 @@ func (s *Service) AuthClient(clientID, secret string) (*models.OauthClient, erro
return client, nil
}

// CheckRedirectURL -> validate the redirect url
func (s *Service) CheckRedirectURL(client *Client, redirectURL string) error {
if redirectURL != client.RedirectURI.String {
return ErrInvalidRedirectURL
}
return nil
}

func (s *Service) createClientCommon(db *gorm.DB, clientID, secret, redirectURI string) (*models.OauthClient, error) {
// Check client ID
if s.ClientExists(clientID) {
Expand Down
1 change: 1 addition & 0 deletions oauth/service_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ type ServiceInterface interface {
AuthUser(username, thePassword string) (*models.OauthUser, error)
GetScope(requestedScope string) (string, error)
Login(client *models.OauthClient, user *models.OauthUser, scope string) (*models.OauthAccessToken, *models.OauthRefreshToken, error)
CheckRedirectURL(client *Client, redirectURL string) error
GrantAuthorizationCode(client *models.OauthClient, user *models.OauthUser, expiresIn int, redirectURI, scope string) (*models.OauthAuthorizationCode, error)
GrantAccessToken(client *models.OauthClient, user *models.OauthUser, expiresIn int, scope string) (*models.OauthAccessToken, error)
GetOrCreateRefreshToken(client *models.OauthClient, user *models.OauthUser, expiresIn int, scope string) (*models.OauthRefreshToken, error)
Expand Down
6 changes: 6 additions & 0 deletions web/authorize.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ func (s *Service) authorize(w http.ResponseWriter, r *http.Request) {
return
}

err = s.oauthService.CheckRedirectURL(client, redirectURI.String())
if err != nil {
errorRedirect(w, r, redirectURI, "invalid_redirect_uri", state, responseType)
return
}

// Grant an access token
accessToken, err := s.oauthService.GrantAccessToken(
client, // client
Expand Down