Remove SORT_REGULAR flag from unique rule #1534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request, @dvdheiden! A few changes before we merge your code. Could you add some tests to cover the new changes and write the reason for the change in the body of the commit message? |
|
I've already added the testcase from the issue to the tests, see: https://github.com/Respect/Validation/pull/1534/files#diff-d86b663dae78d131902ff8c8552a2df8fdf484cb3f882aacd0616e3dbfb0493aR38 which covers this specific problem. I've added the commit message body as you requested. |
|
Thank you so much! However, it seems like you have 3 commits now instead of 1 with the description, I think you will need to rebase your branch |
When SORT_REGULAR is provided to array_unique, it does a loose comparison which makes it think ’14.1’ and ’14.10’ are the same.
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1533