Always display the input #1508
Merged
Always display the input #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "NotBlank", "NotEmpty", and "NotUndef" rules do not display the input in all cases and instead displays the string "The value". The problem with that is that one doesn't see which value was passed, which is not so useful. This commit will changes those rules to always display the input. If someone doesn't want the input to show, they can always set a name for the rule.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
============================================
- Coverage 96.53% 96.52% -0.02%
+ Complexity 972 966 -6
============================================
Files 201 201
Lines 2396 2388 -8
============================================
- Hits 2313 2305 -8
Misses 83 83 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "NotBlank", "NotEmpty", and "NotUndef" rules do not display the input in all cases and instead displays the string "The value". The problem with that is that one doesn't see which value was passed, which is not so useful.
This commit will changes those rules to always display the input. If someone doesn't want the input to show, they can always set a name for the rule.