Trace paths instead of IDs

library/Message/Placeholder/Quoted.php

@@ -16,6 +16,11 @@ public function __construct(
     ) {
     }
 
+    public static function fromPath(int|string $path): self
+    {
+        return new self('.' . $path);
+    }
+
     public function getValue(): string
     {
         return $this->value;

library/Message/StandardFormatter.php

@@ -35,13 +35,19 @@ public function __construct(
     }
 
     /**
-     * @param array<string, mixed> $templates
+     * @param array<string|int, mixed> $templates
      */
     public function main(Result $result, array $templates, Translator $translator): string
     {
         $selectedTemplates = $this->selectTemplates($result, $templates);
         if (!$this->isFinalTemplate($result, $selectedTemplates)) {
             foreach ($this->extractDeduplicatedChildren($result) as $child) {
+                if ($result->path !== null && $child->path !== null) {
+                    $child = $child->withPath(sprintf('%s.%s', $result->path, $child->path));
+                } elseif ($result->path !== null && $child->path === null) {
+                    $child = $child->withPath($result->path);
+                }
+
                 return $this->main($child, $selectedTemplates, $translator);
             }
         }
@@ -50,7 +56,7 @@ public function main(Result $result, array $templates, Translator $translator):
     }
 
     /**
-     * @param array<string, mixed> $templates
+     * @param array<string|int, mixed> $templates
      */
     public function full(
         Result $result,
@@ -91,32 +97,36 @@ public function full(
     }
 
     /**
-     * @param array<string, mixed> $templates
+     * @param array<string|int, mixed> $templates
      *
-     * @return array<string, mixed>
+     * @return array<string|int, mixed>
      */
     public function array(Result $result, array $templates, Translator $translator): array
     {
         $selectedTemplates = $this->selectTemplates($result, $templates);
         $deduplicatedChildren = $this->extractDeduplicatedChildren($result);
         if (count($deduplicatedChildren) === 0 || $this->isFinalTemplate($result, $selectedTemplates)) {
             return [
-                $result->id => $this->renderer->render($this->getTemplated($result, $selectedTemplates), $translator),
+                $result->path ?? $result->id => $this->renderer->render(
+                    $this->getTemplated($result, $selectedTemplates),
+                    $translator
+                ),
             ];
         }
 
         $messages = [];
         foreach ($deduplicatedChildren as $child) {
-            $messages[$child->id] = $this->array(
+            $key = $child->path ?? $child->id;
+            $messages[$key] = $this->array(
                 $child,
                 $this->selectTemplates($child, $selectedTemplates),
                 $translator
             );
-            if (count($messages[$child->id]) !== 1) {
+            if (count($messages[$key]) !== 1) {
                 continue;
             }
 
-            $messages[$child->id] = current($messages[$child->id]);
+            $messages[$key] = current($messages[$key]);
         }
 
         if (count($messages) > 1) {
@@ -165,56 +175,66 @@ private function isAlwaysVisible(Result $result, Result ...$siblings): bool
         );
     }
 
-    /** @param array<string, mixed> $templates */
+    /** @param array<string|int, mixed> $templates */
     private function getTemplated(Result $result, array $templates): Result
     {
         if ($result->hasCustomTemplate()) {
             return $result;
         }
 
-        if (!isset($templates[$result->id]) && isset($templates['__root__'])) {
-            return $result->withTemplate($templates['__root__']);
-        }
+        foreach ([$result->path, $result->name, $result->id, '__root__'] as $key) {
+            if (!isset($templates[$key])) {
+                continue;
+            }
 
-        if (!isset($templates[$result->id])) {
-            return $result;
-        }
+            if (is_string($templates[$key])) {
+                return $result->withTemplate($templates[$key]);
+            }
 
-        $template = $templates[$result->id];
-        if (is_string($template)) {
-            return $result->withTemplate($template);
+            throw new ComponentException(
+                sprintf('Template for "%s" must be a string, %s given', $key, stringify($templates[$key]))
+            );
         }
 
-        throw new ComponentException(
-            sprintf('Template for "%s" must be a string, %s given', $result->id, stringify($template))
-        );
+        return $result;
     }
 
     /**
-     * @param array<string, mixed> $templates
+     * @param array<string|int, mixed> $templates
      */
     private function isFinalTemplate(Result $result, array $templates): bool
     {
-        if (isset($templates[$result->id]) && is_string($templates[$result->id])) {
-            return true;
+        $keys = [$result->path, $result->name, $result->id];
+        foreach ($keys as $key) {
+            if (isset($templates[$key]) && is_string($templates[$key])) {
+                return true;
+            }
         }
 
         if (count($templates) !== 1) {
             return false;
         }
 
-        return isset($templates['__root__']) || isset($templates[$result->id]);
+        foreach ($keys as $key) {
+            if (isset($templates[$key])) {
+                return true;
+            }
+        }
+
+        return isset($templates['__root__']);
     }
 
     /**
-     * @param array<string, mixed> $templates
+     * @param array<string|int, mixed> $templates
      *
-     * @return array<string, mixed>
+     * @return array<string|int, mixed>
      */
-    private function selectTemplates(Result $message, array $templates): array
+    private function selectTemplates(Result $result, array $templates): array
     {
-        if (isset($templates[$message->id]) && is_array($templates[$message->id])) {
-            return $templates[$message->id];
+        foreach ([$result->path, $result->name, $result->id] as $key) {
+            if (isset($templates[$key]) && is_array($templates[$key])) {
+                return $templates[$key];
+            }
         }
 
         return $templates;
@@ -227,16 +247,16 @@ private function extractDeduplicatedChildren(Result $result): array
         $deduplicatedResults = [];
         $duplicateCounters = [];
         foreach ($result->children as $child) {
-            $id = $child->id;
+            $id = $child->path ?? $child->id;
             if (isset($duplicateCounters[$id])) {
                 $id .= '.' . ++$duplicateCounters[$id];
             } elseif (array_key_exists($id, $deduplicatedResults)) {
-                $deduplicatedResults[$id . '.1'] = $deduplicatedResults[$id]?->withId($id . '.1');
+                $deduplicatedResults[$id . '.1'] = $child->path ? $deduplicatedResults[$id]?->withPath($id . '.1') : $deduplicatedResults[$id]?->withId($id . '.1');
                 unset($deduplicatedResults[$id]);
                 $duplicateCounters[$id] = 2;
                 $id .= '.2';
             }
-            $deduplicatedResults[$id] = $child->isValid ? null : $child->withId($id);
+            $deduplicatedResults[$id] = $child->isValid ? null : ($child->path ? $child->withPath((string) $id) : $child->withId((string) $id));
         }
 
         return array_values(array_filter($deduplicatedResults));

library/Message/StandardRenderer.php

@@ -35,7 +35,7 @@ public function __construct(
     public function render(Result $result, Translator $translator, ?string $template = null): string
     {
         $parameters = $result->parameters;
-        $parameters['name'] ??= $result->name ?? $this->placeholder('input', $result->input, $translator);
+        $parameters['name'] ??= $result->name ?? ($result->path !== null ? Quoted::fromPath($result->path) : null) ?? $this->placeholder('input', $result->input, $translator);
         $parameters['input'] = $result->input;
 
         $rendered = (string) preg_replace_callback(

library/Result.php

@@ -39,7 +39,7 @@ public function __construct(
         public readonly ?string $name = null,
         ?string $id = null,
         public readonly ?Result $adjacent = null,
-        public readonly bool $unchangeableId = false,
+        public readonly string|int|null $path = null,
         Result ...$children,
     ) {
         $this->id = $id ?? lcfirst(substr((string) strrchr($rule::class, '\\'), 1));
@@ -102,10 +102,6 @@ public function withExtraParameters(array $parameters): self
 
     public function withId(string $id): self
     {
-        if ($this->unchangeableId) {
-            return $this;
-        }
-
         return $this->clone(id: $id);
     }
 
@@ -114,14 +110,14 @@ public function withIdFrom(Rule $rule): self
         return $this->clone(id: lcfirst(substr((string) strrchr($rule::class, '\\'), 1)));
     }
 
-    public function withUnchangeableId(string $id): self
+    public function withPath(string|int $path): self
     {
-        return $this->clone(id: $id, unchangeableId: true);
+        return $this->clone(adjacent: $this->adjacent?->withPath($path), path: $path);
     }
 
     public function withPrefix(string $prefix): self
     {
-        if ($this->id === $this->name || $this->unchangeableId) {
+        if ($this->id === $this->name || $this->path !== null) {
             return $this;
         }
 
@@ -223,7 +219,7 @@ private function clone(
         ?string $name = null,
         ?string $id = null,
         ?Result $adjacent = null,
-        ?bool $unchangeableId = null,
+        string|int|null $path = null,
         ?array $children = null
     ): self {
         return new self(
@@ -236,7 +232,7 @@ private function clone(
             $name ?? $this->name,
             $id ?? $this->id,
             $adjacent ?? $this->adjacent,
-            $unchangeableId ?? $this->unchangeableId,
+            $path ?? $this->path,
             ...($children ?? $this->children)
         );
     }

library/Rules/Each.php

@@ -28,7 +28,7 @@ protected function evaluateNonEmptyArray(array $input): Result
     {
         $children = [];
         foreach ($input as $key => $value) {
-            $children[] = $this->rule->evaluate($value)->withUnchangeableId((string) $key);
+            $children[] = $this->rule->evaluate($value)->withPath($key);
         }
         $isValid = array_reduce($children, static fn ($carry, $childResult) => $carry && $childResult->isValid, true);
 

library/Rules/Key.php

@@ -13,7 +13,6 @@
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
 use Respect\Validation\Rules\Core\KeyRelated;
-use Respect\Validation\Rules\Core\Nameable;
 use Respect\Validation\Rules\Core\Wrapper;
 
 #[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
@@ -35,21 +34,9 @@ public function evaluate(mixed $input): Result
     {
         $keyExistsResult = (new KeyExists($this->key))->evaluate($input);
         if (!$keyExistsResult->isValid) {
-            return $keyExistsResult->withName($this->getName());
+            return $keyExistsResult->withNameFrom($this->rule);
         }
 
-        return $this->rule
-            ->evaluate($input[$this->key])
-            ->withName($this->getName())
-            ->withUnchangeableId((string) $this->key);
-    }
-
-    private function getName(): string
-    {
-        if ($this->rule instanceof Nameable) {
-            return $this->rule->getName() ?? ((string) $this->key);
-        }
-
-        return (string) $this->key;
+        return $this->rule->evaluate($input[$this->key])->withPath($this->key);
     }
 }

library/Rules/KeyExists.php

@@ -39,7 +39,7 @@ public function getKey(): int|string
 
     public function evaluate(mixed $input): Result
     {
-        return new Result($this->hasKey($input), $input, $this, name: (string) $this->key, id: (string) $this->key);
+        return new Result($this->hasKey($input), $input, $this, path: $this->key);
     }
 
     private function hasKey(mixed $input): bool

library/Rules/Property.php

@@ -13,7 +13,6 @@
 use ReflectionObject;
 use Respect\Validation\Result;
 use Respect\Validation\Rule;
-use Respect\Validation\Rules\Core\Nameable;
 use Respect\Validation\Rules\Core\Wrapper;
 
 #[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
@@ -30,22 +29,12 @@ public function evaluate(mixed $input): Result
     {
         $propertyExistsResult = (new PropertyExists($this->propertyName))->evaluate($input);
         if (!$propertyExistsResult->isValid) {
-            return $propertyExistsResult->withName($this->getName());
+            return $propertyExistsResult->withNameFrom($this->rule);
         }
 
         return $this->rule
             ->evaluate($this->extractPropertyValue($input, $this->propertyName))
-            ->withName($this->getName())
-            ->withUnchangeableId($this->propertyName);
-    }
-
-    private function getName(): string
-    {
-        if ($this->rule instanceof Nameable) {
-            return $this->rule->getName() ?? $this->propertyName;
-        }
-
-        return $this->propertyName;
+            ->withPath($this->propertyName);
     }
 
     private function extractPropertyValue(object $input, string $property): mixed

library/Rules/PropertyExists.php

@@ -36,8 +36,7 @@ public function evaluate(mixed $input): Result
             $this->hasProperty($input),
             $input,
             $this,
-            name: $this->propertyName,
-            id: $this->propertyName
+            path: $this->propertyName,
         );
     }
 

library/Transformers/DeprecatedKeyValue.php

@@ -9,6 +9,7 @@
 
 namespace Respect\Validation\Transformers;
 
+use Respect\Validation\Message\Placeholder\Quoted;
 use Respect\Validation\Rules\AlwaysInvalid;
 use Respect\Validation\Rules\Key;
 use Respect\Validation\Rules\KeyExists;
@@ -52,8 +53,8 @@ static function ($input) use ($comparedKey, $ruleName, $baseKey) {
                     } catch (Throwable) {
                         return new Templated(
                             new AlwaysInvalid(),
-                            '{{baseKey|raw}} must be valid to validate {{comparedKey|raw}}',
-                            ['comparedKey' => $comparedKey, 'baseKey' => $baseKey]
+                            '{{baseKey}} must be valid to validate {{comparedKey}}',
+                            ['comparedKey' => Quoted::fromPath($comparedKey), 'baseKey' => Quoted::fromPath($baseKey)]
                         );
                     }
                 }

tests/feature/AssertWithKeysTest.php

@@ -38,15 +38,15 @@
         ]),
     <<<'FULL_MESSAGE'
     - All the required rules must pass for the given data
-      - All the required rules must pass for mysql
-        - host must be a string
-        - user must be present
-        - password must be present
-        - schema must be a string
-      - All the required rules must pass for postgresql
-        - host must be present
-        - user must be a string
-        - password must be a string
-        - schema must be present
+      - All the required rules must pass for `.mysql`
+        - `.host` must be a string
+        - `.user` must be present
+        - `.password` must be present
+        - `.schema` must be a string
+      - All the required rules must pass for `.postgresql`
+        - `.host` must be present
+        - `.user` must be a string
+        - `.password` must be a string
+        - `.schema` must be present
     FULL_MESSAGE,
 ));