feat: adding hinkal private batch payments #1627
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Batch Payment Support for Hinkal Shielded Addresses
Description
This PR introduces batch payment functionality for Hinkal shielded addresses, allowing users to send multiple payments to different recipients in a single transaction. This feature improves efficiency and reduces gas costs when making multiple private payments.
Key Changes
sendBatchPaymentsToHinkalShieldedAddressesFromPublic
function to support batch paymentsTechnical Details
multiSendPrivateRecipients
under the hoodTesting
Added test case that verifies:
Security Considerations
Jest Configuration Change
isolatedModules
to falseisolatedModules
is true, Jest doesn't transpile dynamic import statements to CommonJS format and, as a result, Jest's VM sandbox uses experimental ES loader features which fail with our test setupisolatedModules
to false ensures proper transpilation of dynamic imports for Jest testing