feat: request network add sdk package #1196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrency and smart-contracts to this package
| "url": "https://github.com/RequestNetwork/requestNetwork/issues" | ||
| }, | ||
| "license": "MIT", | ||
| "dependencies": { |
There was a problem hiding this comment.
the references in here should match the version in the package.json of these packages. Right now, you are resolving the version on NPM, not the monorepo's version
There was a problem hiding this comment.
Hi @benjlevesque thanks for this info, it really helped. Turned out it was because I used the @next modifier (as this has been promoted since I started).
Changed to the correct version(s) and all it well.
The latest commit also includes tsconfig changes to produce es6 output.
github-actions
bot
requested review from
alexandre-abrioux,
benjlevesque,
KolevDarko and
yomarion
skiv71
requested review from
MantisClone
and removed request for
KolevDarko,
alexandre-abrioux and
yomarion
alexandre-abrioux
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181
Changes