Skip to content

chore: cache workflow builds #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2023
Merged

chore: cache workflow builds #21

merged 2 commits into from
Sep 19, 2023

Conversation

yomarion
Copy link
Member

This caches the builds of contracts and mocks in order to save up to 3m30sec of PR check execution in current state.

Pending:

@yomarion yomarion force-pushed the chore/cache-workflow-builds branch from 943e1d3 to 903ebaf Compare September 18, 2023 20:52
Copy link
Member

@MantisClone MantisClone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're trying to do. I'll pre-approve on the grounds that you de-duplicate build-and-test.yml and main.yml.

In the future, when a PR is built on top of a non-main branch, make the PR target the non-main branch. Then, as long as you merge the target, non-main branch to main first, Github will automatically update the target of this PR to the main branch.

For this PR I simplified the diff using: chore/deploy-script-refactor-patch...chore/cache-workflow-builds

@yomarion
Copy link
Member Author

I see what you're trying to do. I'll pre-approve on the grounds that you de-duplicate build-and-test.yml and main.yml.

In the future, when a PR is built on top of a non-main branch, make the PR target the non-main branch. Then, as long as you merge the target, non-main branch to main first, Github will automatically update the target of this PR to the main branch.

For this PR I simplified the diff using: chore/deploy-script-refactor-patch...chore/cache-workflow-builds

@MantisClone It was a draft with no review request for that reason, I wanted #16 to be merged first.

@MantisClone
Copy link
Member

I saw it was a draft. But I also saw you mention it in Slack so I wanted to optimistically approve to not block you further.

@yomarion yomarion force-pushed the chore/cache-workflow-builds branch from 6d80b13 to 6d5600e Compare September 19, 2023 14:19
@yomarion yomarion marked this pull request as ready for review September 19, 2023 14:19
@yomarion yomarion enabled auto-merge (squash) September 19, 2023 14:20
@yomarion yomarion disabled auto-merge September 19, 2023 14:22
@yomarion yomarion merged commit b652d0e into main Sep 19, 2023
@yomarion yomarion deleted the chore/cache-workflow-builds branch September 19, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants