Skip to content

Conversation

slank
Copy link

@slank slank commented Aug 17, 2025

Hello! Thanks for this project it's my new favorite prototyping tool! I was having trouble getting logging output to work the way I wanted and found that there were other folks with similar issues (#18 , #102). I found that logging was being done directly on the module-level functions, which can have undesirable side effects.

I've updated the logging to use the idiomatic, recommended way (see logging docs):

The logger name hierarchy is analogous to the Python package hierarchy, and identical to it if you organise your loggers on a per-module basis using the recommended construction logging.getLogger(__name__). That’s because in a module, name is the module’s name in the Python package namespace.

I've run linting and tests, so this should be a breeze to merge. Hope you agree on the changes. Thanks again!

Copy link
Owner

@RenaudLN RenaudLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good to me :)

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 22:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants