Skip to content

Commit

Permalink
run macOS separately
Browse files Browse the repository at this point in the history
  • Loading branch information
@Remi-Gau
Remi-Gau committed May 8, 2024
1 parent fd14536 commit 03dcdd2
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 70 deletions.
20 changes: 0 additions & 20 deletions .github/workflows/codespell.yml
View file

This file was deleted.

9 changes: 6 additions & 3 deletions .github/workflows/matlab_test_and_coverage.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ name: 'MATLAB: test and coverage'

on:
push:
branches: [master, main, dev]
branches: [main]
pull_request:
branches: ['*']

Expand All @@ -21,8 +21,11 @@ jobs:

strategy:
matrix:
version: [R2021a, R2021b, R2022a, R2022b, R2023a]
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, windows-latest]
version: [R2021a, R2023b]
include:
- os: macos-latest
version: R2023b
fail-fast: false # Don't cancel all jobs if one fails

runs-on: ${{ matrix.os }}
Expand Down
46 changes: 0 additions & 46 deletions .github/workflows/miss_hit.yml
View file

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/octave_test_and_coverage.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: 'Octave: test and coverage'

on:
push:
branches: [master, main, dev]
branches: [main]
pull_request:
branches: ['*']

Expand Down

6 comments on commit 03dcdd2

@mgcooper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please comment on why you deleted codespell.yml and miss_hit.yml? Trying to decide if I should merge these changes. Thank you.

@Remi-Gau
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them because pre-commit is already taking care of running:

And I am relying on pre-commit-ci to run those checks: https://results.pre-commit.ci/

Though your message makes me realize that if someone uses the template but has not set up pre-commit CI then, their code won't get checked by github actions.

I will add a workflow that runs pre-commit to make sure that all use cases are covered.

@Remi-Gau
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of workflows to use pre-commit via github actions to run all the linting and formating (miss-hit, codespell...)

@mgcooper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for that info and for setting up the new workflow.

@mgcooper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Remi-Gau I am not sure why the message about changes to my fork is appearing on your repo landing page (see image below). I did not issue a pull request. I forked the repo and made a few updates to the README then pushed it to my remote/origin, just like a normal fork pull request workflow. I have never seen a message like this appear in an upstream repo landing page (normally it would appear on my forked repo).

Just wanted to let you know in case you're as confused as I am. Maybe something different about a template? Either way, I don't suggest creating a pull request!

Here is a screenshot:

image

@Remi-Gau
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that kind of message is only visible for you (by design I am pretty sure)

this is what I see

image

Please sign in to comment.