Add versioning and improve flag checks under ydotool.c #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems logical that the client has more those info than the server as the server will be probably be run by an init system It was missing on the client to make sure any user can quickly check the hash (hopefully more tags) that is being used
ydotool.c can't control the options using getopt() as it would need to know all the subcommands flags, prefer to be explicit to check only its own options manually as it was before but a bit cleaner Also add the version/hash from build on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting #238, now I only improved the checks and added the VERSION into ydotool, so it can be checked properly which commit/version is being used.
Also should close #245