Support for limiting entries in DbUpdateExceptionDestructurer #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Source/Serilog.Exceptions.EntityFrameworkCore/Serilog.Exceptions.EntityFrameworkCore.csproj
|
This question turns up now and again. Would this help? |
|
@RehanSaeed no, it's less about which properties and more about how many properties across how many objects yielding the log size. i'm not limiting properties in this PR, just how many objects in total are emitted with a hint to say what's been truncated |
|
I also would like to limit the number of entries which will be logged. How can I help so we can merge this PR :) ? |
|
can someone add some tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to use
DbUpdateExceptionDestructurerfor the reasons expressed in the Readme, however some of our processes yield rather large updates that may fail which leads to absolutely massive log entries when an exception is thrown. This causes impact down the line as the logs get shipped to services like Datadog which stop parsing log lines at a certain size which leads to partial unprocessable json, etc.I think the cleanest way to handle this situation is to have an opt-in concept of a maximum quantity of entries that are present in the log.