Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add format validation #1820

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add format validation #1820

wants to merge 3 commits into from

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Dec 10, 2024

What/Why/How?

Added JSON Schema format validation.

Reference

Resolves #766

Testing

  • Add an e2e test.
  • Test in the browser env

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested review from a team as code owners December 10, 2024 10:45
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 9e82900

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Minor
@redocly/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 973.6 ± 48.8 934.8 1096.5 1.00 ± 0.05
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 970.4 ± 12.2 953.9 994.2 1.00

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.67% 5057/6428
🟡 Branches 67.29% 2055/3054
🟡 Functions 73.23% 837/1143
🟡 Lines 78.96% 4769/6040

Test suite run success

836 tests passing in 122 suites.

Report generated by 🧪jest coverage report action from 9e82900

.changeset/angry-taxis-share.md Outdated Show resolved Hide resolved
@tatomyr tatomyr marked this pull request as draft December 10, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate the format of examples
2 participants