-
Notifications
You must be signed in to change notification settings - Fork 237
Enable key placeholder to be combined with other data within the same command argument #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filipecosta90
wants to merge
7
commits into
RedisLabs:master
Choose a base branch
from
filipecosta90:key.placeholder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
039f719
to
54cca7d
Compare
YaacovHazan
requested changes
Jan 28, 2021
…g precomputed prefix and suffix
YaacovHazan
requested changes
May 3, 2021
New Issues (8)Checkmarx found the following issues in this Pull Request
Fixed Issues (9)Great job! The following issues were fixed in this Pull Request
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
This PR adds the option to combine key placeholders with other characters within the same argument. This is important for RedisGraph and RediSearch for us to be able to mix for example node ids with other conditions, etc...
I've used this feature on RG 2.0 benchmark and forgot to open the PR to kick off this feature discussion.
Example of usage:
This PR includes two extra tests