Basic Cypress configuration #667
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 3 3
Lines 23 23
=======================================
Hits 21 21
Misses 2 2 |
justinorringer
added a commit
that referenced
this pull request
Jan 28, 2025
jjaquish
reviewed
Feb 6, 2025
| } | ||
| }); | ||
| require('@cypress/code-coverage/task')(on, config); | ||
| config.port = 8002; |
There was a problem hiding this comment.
Any reason we're insisting on 8002 here?
There was a problem hiding this comment.
None that I have, copy pasted that part! I'll try it out after the drawer move gets finished
| launchOptions.preferences.height = 720; | ||
| } | ||
| }); | ||
| require('@cypress/code-coverage/task')(on, config); |
There was a problem hiding this comment.
I believe this is gonna need to be added to package
|
|
||
| export default defineConfig({ | ||
| component: { | ||
| specPattern: 'cypress/component/**/*.cy.{js,jsx,ts,tsx}', |
There was a problem hiding this comment.
I think you'll need to change this to components or change the folder to component
| @@ -0,0 +1,244 @@ | |||
| import React, { useEffect, useRef, useState } from 'react'; | |||
| import { BrowserRouter } from 'react-router-dom'; | |||
| import DrawerPanel from '../../src/components/NotificationsDrawer/DrawerPanel'; | |||
There was a problem hiding this comment.
Hitting an error here. Does this exist as declared?
There was a problem hiding this comment.
Hey! This is the component we are refactoring to this repo (and why Bryan and I added cypress tests here). PR for that #661
justinorringer
added a commit
that referenced
this pull request
Feb 17, 2025
Hyperkid123
added a commit
that referenced
this pull request
Feb 20, 2025
* working prototype * working base; missing refs * modify panelRef * Passing toggle down and using it onClose() * webpack/cypress files * Testing stuff * mock useChrome function (not working) * Fix component tests * Prettier fixes * disable disallow-fec-relative-imports eslint * Cypress cleanup * Remove cypress configuration (drafted #667) * Moving test data to __test__ * Extra function body suggestion * Various formatting changes * EmptyNotifications to its own file * Swapping jotai to redux * Drafted singleton class * Replacing nested function * Changed to generic getDateDaysAgo * Uninstalling jotai * Moved dropdown components to a different file * Accidentally removed existing cypress import * WIP module nonsense * Debugging shared scope obj * Get unreadnotif * Finally working with JSclients and exposing var in scope and context as fed mod * Its working * Removing context provider * Using JS Client * Moving bell to notifications * Exposing DrawerBell * Removing unused test file --------- Co-authored-by: Blake Holifield <[email protected]> Co-authored-by: Justin Orringer <[email protected]> Co-authored-by: Bryan Florkiewicz <[email protected]> Co-authored-by: Martin Marosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cypress configuration started in notifications drawer refactor
RHCLOUDXXXX
Screenshots
Before:
After:
Checklist ☑️