Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix associated event types drawer info by checking for -1 #665

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

karelhala
Copy link
Contributor

Description

When user clicks on first item in table the event types tab is empty. This is caused by checking for index which can be 0. This PR fixes such issue by checking if the index is undefined and not -1

RHCLOUD-RHCLOUD-37417


Screenshots

Before:

Screenshot 2025-01-21 at 17 24 32

After:

Screenshot 2025-01-21 at 17 24 15


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • [-] (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • [-] (Optional) QE: Has been mentioned
  • [-] (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • [-] (Optional) UX: Has been mentioned

@karelhala karelhala requested a review from a team as a code owner January 21, 2025 16:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (27e8252) to head (cd90b2d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #665   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files           3        3           
  Lines          23       23           
=======================================
  Hits           21       21           
  Misses          2        2           

@karelhala karelhala merged commit ed0e9e4 into RedHatInsights:master Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants