Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time config cancel #663

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

karelhala
Copy link
Contributor

Description

When user cancels the set daily digest modal the value is still present in the description. However after refreshing the correct value is shown. This PR fixes such issue by pulling the timeconfig data when submit happens and when user cancels the modal the timeconfig of server value is used.

RHCLOUD-36282


Screenshots

Before:

Screen.Recording.2025-01-14.at.11.45.34.mov

After:

Screen.Recording.2025-01-14.at.11.44.30.mov

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • [-] (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • _(Optional) QE: Has been mentioned: @Saba7826 FYI
  • [-] (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • [-] (Optional) UX: Has been mentioned

@karelhala karelhala requested a review from a team as a code owner January 14, 2025 10:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (c516efc) to head (7f75ac2).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files           3        3           
  Lines          23       23           
=======================================
  Hits           21       21           
  Misses          2        2           

@fhlavac fhlavac merged commit ce29a99 into RedHatInsights:master Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants