Skip to content

[RHCLOUD-38582] Emit events when editing workspace #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025

Conversation

astrozzc
Copy link
Contributor

@astrozzc astrozzc commented Mar 25, 2025

Link(s) to Jira

Description of Intent of Change(s)

Emit events for HBI to consume

Local Testing

Unit tests

Checklist

  • if API spec changes are required, is the spec updated?
  • are there any pre/post merge actions required? if so, document here.
  • are theses changes covered by unit tests?
  • if warranted, are documentation changes accounted for?
  • does this require migration changes?
    • if yes, are they backwards compatible?
  • is there known, direct impact to dependent teams/components?
    • if yes, how will this be handled?

Secure Coding Practices Checklist Link

Secure Coding Practices Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@astrozzc astrozzc changed the title [DRAFT] Emit events when editing workspace [RHCLOUD-38582] Emit events when editing workspace Mar 27, 2025
@lpichler
Copy link
Contributor

@astrozzc can you rebase please ? 🙏

@lpichler
Copy link
Contributor

lpichler commented Apr 2, 2025

/retest

@lpichler
Copy link
Contributor

lpichler commented Apr 2, 2025

CI:

:24 rbac/management/relation_replicator/outbox_replicator.py:76: error: Argument 1 to "_save_workspace_event" of "OutboxReplicator" has incompatible type "dict[str, Collection[str]]"; expected "WorkspaceEventPayload"  [arg-type]

@astrozzc
Copy link
Contributor Author

astrozzc commented Apr 2, 2025

CI:

:24 rbac/management/relation_replicator/outbox_replicator.py:76: error: Argument 1 to "_save_workspace_event" of "OutboxReplicator" has incompatible type "dict[str, Collection[str]]"; expected "WorkspaceEventPayload"  [arg-type]

fixed

@lpichler
Copy link
Contributor

lpichler commented Apr 2, 2025

/retest

@lpichler lpichler merged commit b6b7b6b into RedHatInsights:master Apr 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants