Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failing by unittest.mock import #279

Merged
merged 1 commit into from
May 28, 2019

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented May 24, 2019

DeleteHostsTestCase.test_create_then_delete fails, because unittest.mock is not imported. Added missing import.

Still I don’t like the usage of unittest.mock here. Please see #280 for more details.

DeleteHostsTestCase.test_create_then_delete fails, because unittest.mock
is not imported. Added missing import.
@Glutexo Glutexo requested review from dehort, jhjaggars and ckyrouac May 24, 2019 16:27
@Glutexo Glutexo self-assigned this May 24, 2019
@dehort dehort merged commit 651f65e into RedHatInsights:master May 28, 2019
@dehort
Copy link
Collaborator

dehort commented May 28, 2019

Weird that this doesn't fail when I run just "pytest". Anyhow...thanks for the fix!

@Glutexo Glutexo deleted the fix_tests_unittest_mock branch June 18, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants