feat(metrics) - RHICOMPL-2412 Add Cloudwatch integration #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
approved these changes
Nov 12, 2021
Victoremepunto
force-pushed
the
add-cloudwatch-logging
branch
5 times, most recently
from
7f1847b to
d6d723d
Compare
|
There's a big issue with need to figure this out before merging. |
|
We hit an issue a long time ago where cloudwatch was configured with the wrong key, but since it broke logging, no one knew it was broken :) Please ensure that the app exits with an error message if cloudwatch is configured but is unable to start. |
Victoremepunto
force-pushed
the
add-cloudwatch-logging
branch
from
d6d723d to
cbc2288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.