Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration flow feedback #118

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Integration flow feedback #118

merged 2 commits into from
Mar 14, 2024

Conversation

josejulio
Copy link
Member

  • anytime => any time
  • Wait 3 secs before opening a new tab

 - anytime => any time
 - Wait 3 secs before opening a new tab
Copy link
Contributor

@justinorringer justinorringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

setTimeout(() => {
const newWindow = window.open(url, '_blank', 'noopener,noreferrer');
if (newWindow) newWindow.opener = null;
}, 3000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll really help!

@justinorringer justinorringer merged commit 614e7e9 into main Mar 14, 2024
2 checks passed
@josejulio josejulio deleted the feedback branch March 14, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants