Skip to content

create sitemap during build step #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025
Merged

create sitemap during build step #443

merged 2 commits into from
Jan 7, 2025

Conversation

maknop
Copy link
Collaborator

@maknop maknop commented Jan 7, 2025

An error was discovered in our SPA that resulted in a 404 for our sitemap.yml file. The gitlab ci build system included an npm command that builds the sitemap.yml file.

This change adds the npm run sitemap directly to the Dockerfile.

@maknop maknop requested review from karelhala and josejulio January 7, 2025 20:39
@josejulio
Copy link
Member

Konflux seems to be failing. Would it be possible that we need some of these parameters?
https://github.com/RedHatInsights/api-documentation-frontend/blob/main/.gitlab-ci.yml#L20
There are also some dependencies being installed there - but not sure what we really require for the sitemap.

@maknop
Copy link
Collaborator Author

maknop commented Jan 7, 2025

Yep was just thinking that @josejulio 😄

Copy link
Member

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maknop maknop merged commit 3c74884 into main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants