fuel reprocessing and more recipes, cleanup of bad itemstack functions #3

funions123 · 2024-10-18T23:43:24Z

I still cant run spotless on my machine btw

TODO:

fill out recipe stubs for basic reactor components
cleanup lang for depleted rods, add the missing ones
create new textures for the basic fuel and depleted rods and add them
properly recolor all crafting ingredient components
add recipes for phosporyl chloride, TBP, distilled water, naq coolant, centrifuging fission product mixture dust
design work and recipes for advanced components (post ic2 vents and such)
add LHE recipes for hot coolants
centrifuging fission product mixture dust, electrolyzing sodium fluoride

Adds the ability to pump distilled water directly into a reactor core and get steam. Efficiency (configurable) currently set at 2x compared to LHE 5x Maximum output per reactor set at around 600 HU/s, based on the size of the output buffer tank.

-Uraninite ore processing and enrichment chain -werkstoff materials support for gregtech crafting items and fluids -gregtech recipe support -fuel rod product class

recipe stubs for basic components and blocks, going to add the regular GTNH recipes to these

RecursivePineapple · 2024-10-19T03:08:50Z

The chem balance for this is really tricky. I'm sure I've made a mistake with one of my comments, so I'd like to see a simple spreadsheet with all of the recipes and the net mols of each chemical (or a doc outlining them all, doesn't matter how you verify it). I'll merge this for now though.

RecursivePineapple · 2024-10-19T01:47:26Z

src/main/java/com/recursive_pineapple/nuclear_horizons/recipes/ChemicalReactor.java

+        //natural uranium hexafluoride
+        GTValues.RA.stdBuilder()
+            .itemInputs(MaterialsNuclear.NATURAL_URANIUM_TETRAFLUORIDE.get(OrePrefixes.dust, 1))
+            .fluidInputs(Materials.Fluorine.getGas(2000))


This looks like it should take 6 fluorine instead of 2

:clueless: I didn't notice that the dust came with fluorine

RecursivePineapple · 2024-10-19T02:51:06Z

src/main/java/com/recursive_pineapple/nuclear_horizons/recipes/ChemicalReactor.java

+            .fluidInputs(MaterialsNuclear.KEROSENE_URANIUM233_SOLUTION.getFluidOrGas(9000))
+            .itemOutputs(MaterialsNuclear.URANIUM_233_DIOXIDE.get(OrePrefixes.dust, 3))
+            .fluidOutputs(
+                new FluidStack(FluidRegistry.getFluid("fluid.kerosene"), 3000), //gt++ moment


Is this supposed to delete 6000 kerosene?

Yes I'm leaning towards both kerosene and TBP being deleted in small amounts as a catalyst, as they are relatively simple to produce. I believe platline deletes ammonia among other inputs so it's not without precedent.
Although deleting 6k kerosene per loop might be too much. I'll probably change it to 2k.

RecursivePineapple · 2024-10-19T02:52:18Z

.../java/com/recursive_pineapple/nuclear_horizons/reactors/items/material/MaterialsNuclear.java

+    public static final Werkstoff TRANSPLUTONIC_WASTE_MIXTURE = new Werkstoff(
+        new short[] { 132, 224, 219 },
+        "Transplutonic Waste Mixture",
+        subscriptNumbers("?Am?"),


Americium is an important progression material. We'll need to either gimp its production here, or gate it behind a ZPM/UV recipe.

Yeah I'm not gonna add a recipe to actually get the americium out until I talk to another dev about gating it properly.

UV electrolyzer/centrifuge is a possibility, since those machines should be post MK3

RecursivePineapple · 2024-10-19T02:58:51Z

src/main/java/com/recursive_pineapple/nuclear_horizons/recipes/ChemicalReactor.java

+                MaterialsNuclear.PLUTONIUM_239_DIOXIDE.get(OrePrefixes.dust, 1),
+                MaterialsNuclear.PLUTONIUM_241_DIOXIDE.get(OrePrefixes.dust, 1))
+            .fluidOutputs(
+                MaterialsNuclear.TRIBUTYL_PHOSPHATE.getFluidOrGas(2000),


I think this needs to be 4k Tributyl Phosphate unless the loss is intentional.
8k tributyl -> 24k treated solution (1x)
24k solution -> 3k aq pu + 21k kerosene uranium (3x)
21k kerosene uranium -> 6k tributyl (1x)
3k aq pu -> 1k tributyl (0.5x)
results in a loss of 1k tributyl per loop

Same with no2. It's got a loss of 1k.

See above comment regarding losses.

RecursivePineapple · 2024-10-19T03:02:48Z

src/main/java/com/recursive_pineapple/nuclear_horizons/recipes/ChemicalReactor.java

+        GTValues.RA.stdBuilder()
+            .itemInputs(
+                GTOreDictUnificator.get(OrePrefixes.dust, Materials.Uraninite, 3))
+            .fluidInputs(Materials.HydrofluoricAcid.getFluid(8000))


I think this needs to be 16k HF. The stoic on the output dust is 4 HF per dust for 4 dust, meaning it requires 16 F. The extra hydrogen can just be voided, it's basically free.

Actually, I think the output is wrong. The uranite input only has 1 mol of uranium but the recipe outputs 4 mol of ?UF4, leading to duplications down the line since the other recipes assume 1 mol of the uranium compounds = 3 uranite / 1 mol uranium.

The stoic here was in error. I've corrected this to use 16000 HF, and changed the centrifuging recipes to turn 36000 H2O and 12000 UF6->4 mol U (1:3 u235/natural and 2:2 u238/natural) and 72000 HF

funions123 and others added 7 commits October 14, 2024 21:21

BWR functionality addition

8f99978

Adds the ability to pump distilled water directly into a reactor core and get steam. Efficiency (configurable) currently set at 2x compared to LHE 5x Maximum output per reactor set at around 600 HU/s, based on the size of the output buffer tank.

Update FluidList.java

bf0f7ea

applied spotless

6c39c63

Uranium ore processing and enrichment, and fuel rod products

1a187c2

-Uraninite ore processing and enrichment chain -werkstoff materials support for gregtech crafting items and fluids -gregtech recipe support -fuel rod product class

Merge remote-tracking branch 'upstream/master'

7d52e35

thorium and uranium fuel reprocessing lines

4620b63

cleanup fluid and itemstack creation, additional recipes

7e98b9f

recipe stubs for basic components and blocks, going to add the regular GTNH recipes to these

RecursivePineapple approved these changes Oct 19, 2024

View reviewed changes

RecursivePineapple merged commit 25e9bc2 into RecursivePineapple:master Oct 19, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fuel reprocessing and more recipes, cleanup of bad itemstack functions #3

fuel reprocessing and more recipes, cleanup of bad itemstack functions #3

funions123 commented Oct 18, 2024 •

edited

Loading

RecursivePineapple commented Oct 19, 2024

RecursivePineapple Oct 19, 2024

RecursivePineapple Oct 19, 2024

RecursivePineapple Oct 19, 2024

funions123 Oct 19, 2024 •

edited

Loading

RecursivePineapple Oct 19, 2024

funions123 Oct 19, 2024

funions123 Oct 19, 2024

RecursivePineapple Oct 19, 2024

RecursivePineapple Oct 19, 2024

funions123 Oct 19, 2024

RecursivePineapple Oct 19, 2024

RecursivePineapple Oct 19, 2024

funions123 Oct 19, 2024 •

edited

Loading

fuel reprocessing and more recipes, cleanup of bad itemstack functions #3

fuel reprocessing and more recipes, cleanup of bad itemstack functions #3

Conversation

funions123 commented Oct 18, 2024 • edited Loading

RecursivePineapple commented Oct 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

funions123 Oct 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

funions123 Oct 19, 2024 • edited Loading

Choose a reason for hiding this comment

funions123 commented Oct 18, 2024 •

edited

Loading

funions123 Oct 19, 2024 •

edited

Loading

funions123 Oct 19, 2024 •

edited

Loading