feat: implemented the get_flag_index_deltas and process_rewards_and_penalties functions #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kayden-ML
changed the title
jihoonsong
reviewed
Feb 12, 2025
Comment on lines
1653
to
1663
| let mut flag_deltas = vec![]; | ||
|
|
||
| for flag_index in 0..PARTICIPATION_FLAG_WEIGHTS.len() { | ||
| let delta = self.get_flag_index_deltas(flag_index as u8)?; | ||
| flag_deltas.push(delta); | ||
| } | ||
|
|
||
| let (penalties_rewards, penalties) = self.get_inactivity_penalty_deltas()?; | ||
|
|
||
| let mut deltas = flag_deltas; | ||
| deltas.push((penalties_rewards, penalties)); |
There was a problem hiding this comment.
Suggested change
| let mut flag_deltas = vec![]; | |
| for flag_index in 0..PARTICIPATION_FLAG_WEIGHTS.len() { | |
| let delta = self.get_flag_index_deltas(flag_index as u8)?; | |
| flag_deltas.push(delta); | |
| } | |
| let (penalties_rewards, penalties) = self.get_inactivity_penalty_deltas()?; | |
| let mut deltas = flag_deltas; | |
| deltas.push((penalties_rewards, penalties)); | |
| let mut deltas = vec![]; | |
| for flag_index in 0..PARTICIPATION_FLAG_WEIGHTS.len() { | |
| deltas.push(self.get_flag_index_deltas(flag_index as u8)?); | |
| } | |
| deltas.push(self.get_inactivity_penalty_deltas()?); |
How about this?
jihoonsong
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented the get_flag_index_deltas, process_rewards_and_penalties functions
https://ethereum.github.io/consensus-specs/specs/altair/beacon-chain/#get_flag_index_deltas
https://ethereum.github.io/consensus-specs/specs/altair/beacon-chain/#rewards-and-penalties