-
Notifications
You must be signed in to change notification settings - Fork 22
refactor(tests): hatch-ify and correct imports in tests #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
|
|
This is a nice improvement, for sure, but it's loosing one thing I like: Yikes! I thought editable pip installs put your project's main source directory into the Pythonpath, not every directory in your source tree. I guess it's every directory in your source with a That means if we have interralated projects each with its own tests in Now, none of this is related to the changes you're proposing, but it makes me think that maybe BTW, in EveryVoice we explicitly exclude the tests from our wheels and sdists with this bit of configuration: (and similar for Something else: I'll want to add this warning filter to There's something I don't understand:
I don't understand why I get this error. If actually installing hatch is required, I would add Anyway, lots of notes here, but the output of |
Thanks! You can just run Happy holidays and new year! |
We use pydub-ng which already guards against this deprecation
Eric likes to do "cd tests" and then, e.g., "./test_misc.py", and this commit makes that possible again.
test_api.py left nul.readalong where it ran
joanise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to apply some further refactorings to the test suites, in particular enabling doing cd tests; ./test_misc.py which I prefer using, otherwise this is great, thanks for figuring how to make pytest work. Good to merge now.
|
Cool, |
PR Goal?
Standardize the directory laout of tests
Fixes?
Fixes: #281
Feedback sought?
Is this easy enough to understand and does it work for you? Should we go all the way and use pytest markers to distinguish the test suites, at which point we can also use
pytest-covto run the testsPriority?
Happy holidays!
Tests added?
Rien ne se perd, rien ne se crée, tout se transforme!
How to test?
hatch test
python run_tests.py
Confidence?
Might want to look it over a bit. Definitely verify the checklist in #281.
Version change?
Nope, just affects tests.