test(IteratorObservable): add spec file for tests on IteratorObservable #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for IteratorObservable, which had none. This improves test coverage. Resolves issue ReactiveX#732.
…or clarity Refactor IteratorObservable a bit, to improve its clarity and robustness (static create does same checks as constructor).
: yay 👍 Changes look good for me. With this change, there are some lines left as uncovered, can I ask if there are further goals or some of constrains does not allow to cover those lines? |
|
It's this issue: #733 |
|
Reading lines of missing coverage makes me assumed it might be related - thanks for clarification. |
|
Meh, we can leave them for now. |
|
Merged with 44e8e79 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage up 0.6%