Skip to content

Proposal for type validation test runner #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Nov 6, 2015

relates to #661

This PR include small code snippet to check basic type definitions as discussed in issue.
There'll be chances of improvement to have additional type detection for verbose output, would like to consider this as starting point.

No actual tests & CI integration included yet.

Output example
image

@kwonoj
Copy link
Member Author

kwonoj commented Nov 6, 2015

cc @robwormald , would like to ask suggestions for output format or any other.

console.log('Error : '.red + message);
console.log(lines[pos.line].gray);
console.log(_.repeat(' ', pos.character) + '^');
console.log();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about console.error()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that could be way. Will update.

@kwonoj kwonoj force-pushed the chore-typevalidate branch from af7bab9 to fa0a93c Compare November 7, 2015 17:44
@kwonoj
Copy link
Member Author

kwonoj commented Nov 7, 2015

Small update suggestion from @staltz to use console.error with minor output changes.

image

@benlesh
Copy link
Member

benlesh commented Nov 9, 2015

This is interesting. How long does it take to run, on average? (I'll pull it down sometime soon and give it a try, too)

@kwonoj
Copy link
Member Author

kwonoj commented Nov 9, 2015

What I did was just small code snippet does not reflect real world cases (having lot of files, or codes) though, it took about a second. For comparison reference, on same system typescript build takes around 14 sec, unit test takes around 2.3 second.

@benlesh
Copy link
Member

benlesh commented Nov 10, 2015

@trxcllnt ... what are your thoughts?

@kwonoj kwonoj added the blocked label Nov 20, 2015
@kwonoj
Copy link
Member Author

kwonoj commented Nov 20, 2015

Marked this as blocked while exploring feasibility of migrating unit test cases to typescript based.

@benlesh
Copy link
Member

benlesh commented Jan 25, 2016

@kwonoj I'm going to close this for now since discussion here is dead. We can open a new issue for it to create more discussion, or we can discuss off-line and open an issue when we have some plans outlined.

@benlesh benlesh closed this Jan 25, 2016
@kwonoj
Copy link
Member Author

kwonoj commented Jan 25, 2016

Agreed, thanks.

@kwonoj kwonoj deleted the chore-typevalidate branch March 8, 2016 20:45
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants