-
Notifications
You must be signed in to change notification settings - Fork 3k
Proposal for type validation test runner #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @robwormald , would like to ask suggestions for output format or any other. |
console.log('Error : '.red + message); | ||
console.log(lines[pos.line].gray); | ||
console.log(_.repeat(' ', pos.character) + '^'); | ||
console.log(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about console.error()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that could be way. Will update.
af7bab9
to
fa0a93c
Compare
Small update suggestion from @staltz to use console.error with minor output changes. |
This is interesting. How long does it take to run, on average? (I'll pull it down sometime soon and give it a try, too) |
What I did was just small code snippet does not reflect real world cases (having lot of files, or codes) though, it took about a second. For comparison reference, on same system typescript build takes around 14 sec, unit test takes around 2.3 second. |
@trxcllnt ... what are your thoughts? |
Marked this as blocked while exploring feasibility of migrating unit test cases to typescript based. |
@kwonoj I'm going to close this for now since discussion here is dead. We can open a new issue for it to create more discussion, or we can discuss off-line and open an issue when we have some plans outlined. |
Agreed, thanks. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
relates to #661
This PR include small code snippet to check basic type definitions as discussed in issue.
There'll be chances of improvement to have additional type detection for verbose output, would like to consider this as starting point.
No actual tests & CI integration included yet.
Output example
