chore(test): expand browser coverage #1133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relates to #998 . |
|
Merged with d2e852c. |
|
@kwonoj how about adding a big Sauce Labs banner showing the browser support? In Cycle.js we do this in README.md:
|
|
@staltz That's plan, after moving test execution account. Currently test is executed via my account, (https://saucelabs.com/u/ojkwon) and account for RxJS need to be created. Once it's done, I'll add big, shine green banner to repo. :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sets are 'known good' coverage, while other browser version / platforms are failing for some reason requires some of codebase updates (i.e, ie fails by promise impl, edge fails by test hang, etcs..) which'll be updated further.