-
Notifications
You must be signed in to change notification settings - Fork 3k
Connect saucelabs testing environment with travis #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c104b6
to
c297714
Compare
looks ok. |
c297714
to
94f42ee
Compare
Applied minor update into PR to trigger karma test only if
allows to not to block any travis jobs by browser test. |
I'd almost prefer it did run if it's a PR too... We wouldn't want to merge a PR that was going to break a browser we're targeting, right?
What do we need to do to get this working under a more generic account, like a "ReactiveX" account? I've not dealt with Sauce Labs. @jeffbcross @IgorMinar: Have you guys dealt with this? |
: I hope that too but travis says clearly it's not supported and there won't be any plan for it. If there's possible way to establish this, it should be included.
: Creating new account with right user name 'reactivex' in this case, and ask saucelabs to switch them into OSS would work. For this PR, I've used my own at least to ensure it works. Switching account is fairly straightforward and simple, only requires to replace environment variables in travis configuration. (Means, this PR does not have any reference to my account and does not have constraint to be merged due to account) |
: I'd like to do this gladly but creating account requires mail address which should not be mine for official reactivex account, leaving it from my hand. |
@kwonoj does the account just need to be a part of the ReactiveX organization? |
@Blesh I do see they allow to add 'member' under primary account, but in this case I'd rather suggest to create separate account per repo such as Primary reason for those is to allow maximum concurrency between repo, OSS account allows 5 maximum concurrent VM so if creating one single account and use it among different repo, it could easily create bottleneck for test. Course caveat is each repo requires separate account to be maintained.. |
The current situation is not pretty. I can give you a rundown but what you SauceLabs supposedly developed an JWT Addon but to my knowledge Travis On Mon, Dec 14, 2015 at 5:03 PM OJ Kwon [email protected] wrote:
|
My take on this is let establish testing on master branch first and looking possible solutions for PR also , by given status of testing PR is not immediately available. |
My gut tells me that merging this probably won't hurt. I'm not sure how I can verify if it's going to be okay without merging it, honestly. So... LGTM? Maybe? @kwonoj would you like to rebase and merge this and we can see how it works out? |
: Yes, due to current circumstances it's not avail to verify before merge :( Will do check in myself, verify using my account to see results. Once it says it's ok, then we can create fresh new account for official RxJS to connect it actually. Will update status shortly. |
Merged with 70b1997. Not closing this yet until completes
|
Connection's verified successfully and having 1 failed test in browser https://saucelabs.com/tests/dcade6598d344ae1a6b0d54b28e1031e
I have experience similar before one of my VM environment, suspect due to async test. I'll try to look address this separately. Meanwhile, @Blesh - I think you can create saucelabs account for RxJS now. |
To be clear, test fails only on Chrome 46 while FF passes. |
PR #1129 is created to avoid async test failure. |
Now test are successfully connected without failure, account is remaining item to close this. |
On second thought, I'll close this issue since change itself is already in to prevent any accidental additional merge attempt. Connecting actual account doesn't need codebase changes (can be configured in travis), can be tracked in issue #998. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR now connects travis to saucelabs (https://saucelabs.com/) to execute browser test with karma.
Few notes: