-
Notifications
You must be signed in to change notification settings - Fork 3k
Browser support #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Think ES5 need to be supported. Not sure about node - RxJS4 supports node 0.4+ but node has been updated quite amount - maybe support lowest stable version? |
I think it's just: Browser support: IE9+
Promise is being injected in those tests now for just that reason, I believe. |
Really until we have these tests running in something like Karma, testing in multiple browsers is going to be difficult. Also, there are a lot of CI tools that integrate with Travis that will test against multiple browsers and platforms, we should definitely look into that. Also, if we do that, we can use a library that polyfills Promise (I think Bluebird does this). |
I'm going to close this in favor of #998. We're supporting IE9+, Node 0.12+, and as many modern mobile browsers as we can test. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What is the "lowest common denominator" that RxJS 5 will target?
Do we support only ES6? Do we support ES5?
These questions came up when I was working on getting coverage for #732, and noticed how in Node 4.2.1 the code related to polyfilling ArrayIterator and StringIterator is never reached because of course, those exist already in Node 4.2.1.
Should we run tests using node v0.10.x? I tried that and many tests failed because of missing
Promise
etc.The text was updated successfully, but these errors were encountered: