Skip to content

Browser support #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
staltz opened this issue Nov 16, 2015 · 5 comments
Closed

Browser support #733

staltz opened this issue Nov 16, 2015 · 5 comments

Comments

@staltz
Copy link
Member

staltz commented Nov 16, 2015

What is the "lowest common denominator" that RxJS 5 will target?

Do we support only ES6? Do we support ES5?

These questions came up when I was working on getting coverage for #732, and noticed how in Node 4.2.1 the code related to polyfilling ArrayIterator and StringIterator is never reached because of course, those exist already in Node 4.2.1.

Should we run tests using node v0.10.x? I tried that and many tests failed because of missing Promise etc.

@kwonoj
Copy link
Member

kwonoj commented Nov 16, 2015

Think ES5 need to be supported. Not sure about node - RxJS4 supports node 0.4+ but node has been updated quite amount - maybe support lowest stable version?

@benlesh
Copy link
Member

benlesh commented Nov 16, 2015

I think it's just:

Browser support: IE9+
Node Support: 0.12+

Should we run tests using node v0.10.x? I tried that and many tests failed because of missing Promise etc.

Promise is being injected in those tests now for just that reason, I believe.

@benlesh
Copy link
Member

benlesh commented Nov 18, 2015

Really until we have these tests running in something like Karma, testing in multiple browsers is going to be difficult. Also, there are a lot of CI tools that integrate with Travis that will test against multiple browsers and platforms, we should definitely look into that.

Also, if we do that, we can use a library that polyfills Promise (I think Bluebird does this).

@benlesh
Copy link
Member

benlesh commented Dec 14, 2015

I'm going to close this in favor of #998.

We're supporting IE9+, Node 0.12+, and as many modern mobile browsers as we can test.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants