Javadoc: Overveable.takeWhile vs. takeUntil: the condition is inverted#7856
Closed
ePaul wants to merge 1 commit intoReactiveX:3.xfrom
Closed
Javadoc: Overveable.takeWhile vs. takeUntil: the condition is inverted#7856ePaul wants to merge 1 commit intoReactiveX:3.xfrom
ePaul wants to merge 1 commit intoReactiveX:3.xfrom
Conversation
…akeUntil. The current description of the difference between takeWhile and takeUntil just points to the evaluation time (before or after the element is emitted), but the (IMHO) more important fact is that the predicate is inverted between both: one emits just elements where the predicate is true, the other just elements where the predicate is false (and the first true one).
Author
Member
|
The naming of I prefer not to change the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description of the difference between takeWhile and takeUntil just points to the evaluation time (before or after the element is emitted), but the (IMHO) more important fact is that the predicate is inverted between both:
takeWhileemits just elements where the predicate is true,takeUntiljust elements where the predicate is false (and the first true one).