Update Conjugate-Computational Variational Message Passing Notebook (CVI -> CVIProjection) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have deprecated the CVI method, which I am updating here to CVIProjection. The only thing that we need to take into account is that DivisionOf, which CVIProjection can produce as a message (or part of the posterior), is actually used here, so some extra functionality in ReactiveMP is needed to support this feature. More specifically, when we have a product of a division with something such that their product can be resolved to a distribution, we should do it. The supporting ReactiveMP PR is here: ReactiveBayes/ReactiveMP.jl#479. But suggestions for how this could be implemented differently are obviously welcome.