Skip to content

[Task] Implement Terms of Service Page #96 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MozzamShahid
Copy link

pp tsx and LoginModal TermofService Footer Link Updated

Description

  • Added a Terms of Service page under the pages/ directory.
  • Updated App.tsx to include the new route.
  • Modified the login modal footer 1 link to of the Terms page. "/terms-of-services"

Closes #(issue)

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD (updates related to the CI/CD process)
  • Documentation update (changes to docs/code comments)
  • Chore (miscellaneous tasks that do not fall into the above options)

What is the proposed approach?

Page Creation: for term of service page add the term of service content there with material ui css

Please give a short overview/explanation on the approach taken to resolve the issue(s).
Term of Service Page Created

Checklist:

  • [ X] The commit message follows our adopted guidelines
  • [X ] Testing has been done for the change(s) added (for bug fixes/features)
  • [X ] Relevant comments/docs have been added/updated (for bug fixes/features)

pp tsx and LoginModal TermofService Footer Link Updated
Copy link
Member

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MozzamShahid, thank you for the PR! A small change required (might be tedious). Noted that you've directly included the contents of the terms of service within the page file itself. To cater for i18n, these content should actually be moved here: https://github.com/React-ChatBotify/gallery-website/tree/main/public/locales/en/pages

@MozzamShahid
Copy link
Author

Hi @tjtanjin New Term of Service Text Page is now added according to the policy. Please review the updated pull request. Thank you apologize for unavailability. i got a job and was busy there. now i am available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants