Release Cycle Fade Shape (Mousewheel) v1.0 #1604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfillion
reviewed
Jul 4, 2025
Comment on lines
+72
to
+74
| wheel_dir = 1 -- wheel up | ||
| elseif val < 0 then | ||
| wheel_dir = -1 -- wheel down |
There was a problem hiding this comment.
Up/down is inverted: scrolling up selects the previous fade & vice versa (ignore if it's the intended behavior).
Comment on lines
+58
to
+66
| local is_new, name, midi_val = reaper.MIDI_GetRecentInputEvent(0) | ||
|
|
||
| if is_new then | ||
| if midi_val == 1 then -- wheel up | ||
| wheel_dir = 1 | ||
| elseif midi_val == 127 then -- wheel down | ||
| wheel_dir = -1 | ||
| end | ||
| end |
There was a problem hiding this comment.
This appears to be bogus? The third return value of MIDI_GetRecentInputEvent is "timestamp in samples relative to the current position".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.