Skip to content

Release Smart Tempo Ripple v1.5 #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

muorsic
Copy link

@muorsic muorsic commented May 3, 2025

Version 1.5 April 29th 2025
-- Prevent UI refresh

@cfillion
Copy link
Member

cfillion commented May 3, 2025

The script's name should be in sentence case to match native REAPER actions and other ReaScripts. However it's unclear what is the actual desired name of the script:

  • "Smart tempo ripple" as per the current filename/description
  • "Smart tempo changes" as per the undo point name (Undo_EndBlock)
  • "Smart tempo and time signature changes" as per the forum thread title
  • "Smart tempo changes – Ripple time signatures" as per the forum thread body

@muorsic
Copy link
Author

muorsic commented May 3, 2025

Hi cfillion,
thanks for reviewing this. yes it does use:
Tempo envelope: Insert tempo/time signature change marker at edit cursor...
But we can't use / or : in the name . And is this too long?
Tempo envelope- Insert tempo time signature change marker at edit cursor, avoiding partial measures and added beats.
Also - will I update the script here or on the ReaPack website?

@cfillion
Copy link
Member

cfillion commented May 3, 2025

I meant that it should use the same capitalization style as the existing actions (REAPER uses sentence case rather than Title Case), not that it should match "Tempo envelope: Insert tempo/time signature change marker at edit cursor" specifically.

(But if that's the name you prefer, it's perfectly fine even if it's on the longer side.)

Any name you choose should also be consistent between the filename, @description, undo point, and preferably how it's announced on the forum. So that it's easy to find.

If a user reads "Smart tempo changes – Ripple time signatures" on the forum and then tries to search that in ReaPack, they won't find it if it's named "Smart tempo ripple" here.

You can edit the files directly here or restarting on reapack.com/upload. Whichever you're more comfortable with.

…po and time signature changes.lua

changed names + undo point and updated to version 1.6
@muorsic
Copy link
Author

muorsic commented May 6, 2025

Hi cfillion,
how does it look now?

Thanks and sorry for the trouble.
btw, thanks for all your amazing scripts !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants