Skip to content

feat(Spotify - Custom theme): Add option to use unmodified player background gradient #4741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 13, 2025
Merged

feat(Spotify - Custom theme): Add option to use unmodified player background gradient #4741

merged 15 commits into from
Apr 13, 2025

Conversation

Nuckyz
Copy link
Contributor

@Nuckyz Nuckyz commented Apr 5, 2025 •
edited by LisoUseInAIKyrios
Loading

Adds a patching option to override the player background gradient with the custom background color.

Disabled (default) Enabled (AMOLED black background)
Image Image

@LisoUseInAIKyrios

This comment was marked as resolved.

Sign in to view
@Nuckyz

This comment was marked as resolved.

Sign in to view
@Nuckyz

This comment was marked as resolved.

Sign in to view
@LisoUseInAIKyrios

This comment was marked as resolved.

Sign in to view
@Nuckyz

This comment was marked as resolved.

Sign in to view
@LisoUseInAIKyrios

This comment was marked as resolved.

Sign in to view
@Nuckyz

This comment was marked as resolved.

Sign in to view
@Nuckyz

This comment was marked as resolved.

Sign in to view
@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 5, 2025

@LisoUseInAIKyrios This PR now closes #4740

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Apr 5, 2025 that may be closed by this pull request
bug(Spotify - Custom theme): Patch fails to apply in version 9.0.36.131 #4740
Closed
3 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title chore(Spotify): Refactor Unlock Premium and CustomTheme patch fix(Spotify - Custom theme): Support latest app target Apr 5, 2025
@LisoUseInAIKyrios
Copy link
Contributor

Could also implement
#4727 by adding an additional optional patch option for the player background color.

That could be another PR but it's related to the changes here (and the player background changes have not reached main yet).

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 6, 2025

Could also implement #4727 by adding an additional optional patch option for the player background color.

That could be another PR but it's related to the changes here (and the player background changes have not reached main yet).

Will take a look into it

@Nuckyz Nuckyz requested a review from LisoUseInAIKyrios April 8, 2025 21:47
@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 8, 2025

This PR now closes #4727

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Apr 8, 2025 that may be closed by this pull request
feat(Spotify - Custom theme): Separate option for player background color #4727
Closed
3 tasks
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(Spotify - Custom theme): Support latest app target feat(Spotify - Custom theme): Add option to use unmodified player background gradient Apr 8, 2025
@YT-Advanced
Copy link

Can we add MaterialYou support 👀

@ILoveOpenSourceApplications
Copy link
Contributor

I don't know if it's within the scope of this PR, but what about #1891?

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 10, 2025

I don't know if it's within the scope of this PR, but what about #1891?

I dont want to fix the accent colors right now. It's kinda of minimum importance in my opinion.

@LisoUseInAIKyrios LisoUseInAIKyrios removed the request for review from oSumAtrIX April 10, 2025 13:40
oSumAtrIX
oSumAtrIX reviewed Apr 11, 2025
View reviewed changes
patches/api/patches.api
Comment on lines +1518 to +1520
public static final fun addInstructionsAtControlFlowLabel (Lapp/revanced/patcher/util/proxy/mutableTypes/MutableMethod;ILjava/lang/String;)V
public static final fun containsLiteralInstruction (Lcom/android/tools/smali/dexlib2/iface/Method;D)Z
public static final fun containsLiteralInstruction (Lcom/android/tools/smali/dexlib2/iface/Method;F)Z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can soon look into moving helper functions into a separate Gradle module in the patcher repository. The module would be published as a separate maven package and could be used by patches, or other repos that might wanna use them. We could also get rid of all these extension functions we arbitrarily chose to create in the patcher repo and move them to the gradle module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReVanced/revanced-patcher#337

@oSumAtrIX
Copy link
Member

What is meant with Add option to use unmodified player background gradient in the PR title?

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 11, 2025

What is meant with Add option to use unmodified player background gradient in the PR title?

The current theme patch overrides the gradient color which songs from every song in the player view, the one where you can view song name, artist info, lyrics. This PR adds an option to control that behavior, along with other fixes and refactors.

@LisoUseInAIKyrios LisoUseInAIKyrios removed a link to an issue Apr 12, 2025
bug(Spotify - Custom theme): Patch fails to apply in version 9.0.36.131 #4740
Closed
3 tasks
@MondayNitro
Copy link

can you also add an option to make statusbar transparent? i remember some old mods had it

Screenshot 2025-04-13 125353

@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into spotify/refactor
61b263b 
# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/spotify/layout/theme/CustomThemeBytecodePatch.kt
@LisoUseInAIKyrios
Finish merge
d0405ed
@LisoUseInAIKyrios
Copy link
Contributor

Anything left todo here?

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 13, 2025

Anything left todo here?

Can you test if the voice assistant patches work in the legacy version? If yes then the early return should be moved down

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 13, 2025

Besides that, this PR can be merged. More fixes can be added in a future PR if needed.

@LisoUseInAIKyrios
Copy link
Contributor

This PR doesn't change anything with voice assistant.

Voice assistant attributes seems to be present with the legacy app target.

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 13, 2025

This PR doesn't change anything with voice assistant.

Voice assistant attributes seems to be present with the legacy app target.

It doesn't change anything, however the current implementation returns before voice assistant is patched. This can be sneeked inside this PR and fixed.

@LisoUseInAIKyrios
Copy link
Contributor

Oh that change. I checked and the fingerprint doesn't resolve with the legacy target.

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 13, 2025

Oh that change. I checked and the fingerprint doesn't resolve with the legacy target.

Ahh I see, seems fine then

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 0ee3693 into ReVanced:dev Apr 13, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 13, 2025
@semantic-release-bot
chore: Release v5.20.0-dev.2 [skip ci]
a6b5d04 
# [5.20.0-dev.2](v5.20.0-dev.1...v5.20.0-dev.2) (2025-04-13)

### Features

* **Spotify - Custom theme:** Add option to use unmodified player background gradient ([#4741](#4741)) ([0ee3693](0ee3693))
github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
@semantic-release-bot
chore: Release v5.20.0 [skip ci]
c5d1702 
# [5.20.0](v5.19.1...v5.20.0) (2025-04-15)

### Bug Fixes

* **Duolingo - Hide ads:**  Support lastest app release ([#4790](#4790)) ([215fccb](215fccb))
* **Spotify - Unlock Spotify Premium:** Remove premium restriction for 'Spotify Connect' ([#4782](#4782)) ([50f5b1a](50f5b1a))
* **Spotify:** Fix login by replacing `Spoof signature` patch with new `Spoof package info` patch ([#4794](#4794)) ([d639151](d639151))
* **YouTube - Remove background playback restrictions:** Restore PiP button functionality after screen is unlocked ([6837348](6837348))

### Features

* Add `Set target SDK version 34` patch (Disable edge-to-edge display) ([#4780](#4780)) ([dcf6178](dcf6178))
* **Spotify - Custom theme:** Add option to use unmodified player background gradient ([#4741](#4741)) ([0ee3693](0ee3693))
* **YouTube - Swipe controls:** Add option to change volume swipe sensitivity (step size) ([#4557](#4557)) ([8957325](8957325))
@LisoUseInAIKyrios LisoUseInAIKyrios mentioned this pull request Apr 15, 2025
Merged
@Nuckyz Nuckyz deleted the spotify/refactor branch April 16, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX oSumAtrIX left review comments

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(Spotify - Custom theme): Separate option for player background color
6 participants
@Nuckyz @LisoUseInAIKyrios @YT-Advanced @ILoveOpenSourceApplications @oSumAtrIX @MondayNitro